From 394560e23c00c0b08106c434b166601c59e97ce9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Erik=20Hedenstro=CC=88m?= <erik@hedenstroem.com>
Date: Thu, 23 May 2024 01:04:07 +0200
Subject: [PATCH] Improved tests

---
 cmd/read.go        | 18 ++++++++++++++++++
 vault/http_test.go | 26 ++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)
 create mode 100644 vault/http_test.go

diff --git a/cmd/read.go b/cmd/read.go
index 8b29c93..4c46217 100644
--- a/cmd/read.go
+++ b/cmd/read.go
@@ -28,6 +28,24 @@ var readCmd = &cobra.Command{
 				"args": ["secret/test"],
 				"output": "/hello/"
 			},
+			{
+				"name": "Read secret - default",
+				"needs": ["Write secret","Write secret from stdin"],
+				"args": ["-s","secret/test"],
+				"output": "/hello/"
+			},
+			{
+				"name": "Read secret - ps",
+				"needs": ["Write secret","Write secret from stdin"],
+				"args": ["-s","ps","secret/test"],
+				"output": "/hello/"
+			},
+			{
+				"name": "Read secret - cmd",
+				"needs": ["Write secret","Write secret from stdin"],
+				"args": ["-s","cmd","secret/test"],
+				"output": "/hello/"
+			},
 			{
 				"name": "Read secret deleted",
 				"needs": ["Delete secret goodbye"],
diff --git a/vault/http_test.go b/vault/http_test.go
new file mode 100644
index 0000000..c82e066
--- /dev/null
+++ b/vault/http_test.go
@@ -0,0 +1,26 @@
+package vault
+
+import (
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestMain(m *testing.M) {
+	exitVal := m.Run()
+	os.Exit(exitVal)
+}
+
+func TestBadVaultAddr(t *testing.T) {
+	t.Setenv("VAULT_ADDR", "http://dne")
+	_, err := GetSecret("secret/data/test")
+	require.Error(t, err)
+}
+
+func TestBadVaultToken(t *testing.T) {
+	t.Setenv("VAULT_ADDR", "http://vault.hedenstroem.com")
+	t.Setenv("VAULT_TOKEN", "dne")
+	_, err := GetSecret("secret/data/test")
+	require.Error(t, err)
+}
-- 
GitLab